Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QE]fix e2e failure on arm64 #4541

Merged
merged 1 commit into from
Jan 6, 2025
Merged

[QE]fix e2e failure on arm64 #4541

merged 1 commit into from
Jan 6, 2025

Conversation

lilyLuLiu
Copy link
Contributor

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

Test case 'Overall cluster health' and 'Mirror image to OpenShift image registry' failed on arm64.
Remove the arch specific when pull image

Testing

Contribution Checklist

  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

@openshift-ci openshift-ci bot requested review from adrianriobo and evidolob January 3, 2025 10:23
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 3, 2025

@lilyLuLiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 857108b link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

praveenkumar
praveenkumar reviewed Jan 6, 2025
View reviewed changes
test/e2e/features/story_openshift.feature
@@ -41,7 +41,7 @@ Feature: 4 Openshift stories
Given executing "oc new-project testproj" succeeds
# mirror
When executing "oc registry login --insecure=true" succeeds
Then executing "oc image mirror registry.access.redhat.com/ubi8/httpd-24:latest=default-route-openshift-image-registry.apps-crc.testing/testproj/hello:test --insecure=true --filter-by-os=linux/amd64" succeeds
Then executing "oc image mirror registry.access.redhat.com/ubi8/httpd-24:latest=default-route-openshift-image-registry.apps-crc.testing/testproj/hello:test --insecure=true" succeeds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@openshift-ci openshift-ci bot added the lgtm label Jan 6, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 6, 2025
@praveenkumar praveenkumar merged commit c133e01 into crc-org:main Jan 6, 2025
28 of 36 checks passed
@lilyLuLiu lilyLuLiu mentioned this pull request Jan 7, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenkumar praveenkumar praveenkumar approved these changes

@adrianriobo adrianriobo Awaiting requested review from adrianriobo

@evidolob evidolob Awaiting requested review from evidolob

Assignees

@praveenkumar praveenkumar

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilyLuLiu @praveenkumar